sparklines bugfix

when using an empty segment parameter, clicking a sparkline resulted in the error "Segment parameter 'undefined' does not appear to have a valid format."
matomo-org · Apr 12, 2013 · e11dbdb · e11dbdb
1 parent 09690c2
commit e11dbdb
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/plugins/CoreHome/templates/sparkline.js b/plugins/CoreHome/templates/sparkline.js
@@ -22,7 +22,12 @@ function initializeSparklines() {
                     delete params[sparklineUrlParamsToIgnore[i]];
                 }
                 for (var key in params) {
-                    params[key] = decodeURIComponent(params[key]);
+                    if (typeof params[key] == 'undefined') {
+                        // this happens for example with an empty segment parameter
+                        delete params[key];
+                    } else {
+                        params[key] = decodeURIComponent(params[key]);
+                    }
                 }
 
                 // on click, reload the graph with the new url