refs #4747 verify user has at least view access for the site

plugins/ScheduledReports/API.php

@@ -12,9 +12,11 @@
 use Piwik\Common;
 use Piwik\Date;
 use Piwik\Db;
+use Piwik\NoAccessException;
 use Piwik\Piwik;
 use Piwik\Plugins\LanguagesManager\LanguagesManager;
 use Piwik\Plugins\SegmentEditor\API as APISegmentEditor;
+use Piwik\Plugins\SitesManager\API as SitesManagerApi;
 use Piwik\ReportRenderer;
 use Piwik\ReportRenderer\Html;
 use Piwik\Site;
@@ -288,8 +290,11 @@ public function generateReport($idReport, $date, $language = false, $outputType
         $report = reset($reports);
 
         $idSite = $report['idsite'];
+        $login  = $report['login'];
         $reportType = $report['type'];
 
+        $this->checkUserHasViewPermission($login, $idSite);
+
         // override report period
         if (empty($period)) {
             $period = $report['period'];
@@ -935,4 +940,19 @@ private function createAttachment($report, $processedReport, $prettyDate)
 
         return $additionalFile;
     }
+
+    private function checkUserHasViewPermission($login, $idSite)
+    {
+        if (empty($idSite)) {
+            return;
+        }
+
+        $idSitesUserHasAccess = SitesManagerApi::getInstance()->getSitesIdWithAtLeastViewAccess($login);
+
+        if (empty($idSitesUserHasAccess)
+            || !in_array($idSite, $idSitesUserHasAccess)
+        ) {
+            throw new NoAccessException(Piwik::translate('General_ExceptionPrivilege', array("'view'")));
+        }
+    }
 }

plugins/SitesManager/API.php

@@ -340,6 +340,10 @@ public function getSitesIdWithAtLeastViewAccess($_restrictSitesToLogin = false)
                 || TaskScheduler::isTaskBeingExecuted())
         ) {
 
+            if (Piwik::hasTheUserSuperUserAccess($_restrictSitesToLogin)) {
+                return Access::getInstance()->getSitesIdWithAtLeastViewAccess();
+            }
+
             $accessRaw = Access::getInstance()->getRawSitesWithSomeViewAccess($_restrictSitesToLogin);
             $sitesId = array();
             foreach ($accessRaw as $access) {