Skip to content

Commit

Permalink
refs #57 some UI tweaks
Browse files Browse the repository at this point in the history
  • Loading branch information
tsteur committed Mar 5, 2014
1 parent 2debd09 commit 593dbc8
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
3 changes: 2 additions & 1 deletion plugins/Insights/lang/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"TitleConsideredVisits": "Considered rows having at least a growth of at least %s%% compared to %s.",
"TitleConsideredChanges": "Considered movers only if they increased or decreased by more than %s visits, new entries only if they increase by more than %s visits, and disappeared rows if they decreased by more than %s visits based on %s total visits.",
"TitleReportBasedOn": "Based on %s %s, rows less than %s %s were ignored",
"TitleRowChangeDetails": "'%s' changed from %s (%s) to %s (%s) %s"
"TitleRowChangeDetails": "'%s' changed from %s (%s) to %s (%s) %s",
"TitleIgnoredChanges": "Changes affecting less than %s visits were ignored."
}
}
4 changes: 2 additions & 2 deletions plugins/Insights/templates/insightControls.twig
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
<hr style="height: 1px;border: 0px;background-color: #cccccc;" />

Filter

{% if properties.show_filter_by %}
<select size="1" name="filterBy" title="Show all, only movers, only new, only disappeared">
<option {% if not properties.filter_by %}selected{% endif %} value="">All</option>
Expand All @@ -55,7 +55,7 @@

<select size="1" name="showIncreaseOrDecrease" title="Show increaser and/or decreaser">
<option value="both" {% if properties.limit_increaser and properties.limit_decreaser %}selected{%endif%}>
All
Increaser & decreaser
</option>
<option value="increase" {% if properties.limit_increaser and not properties.limit_decreaser %}selected{%endif%}>
Only increaser
Expand Down
7 changes: 6 additions & 1 deletion plugins/Insights/templates/insightVisualization.twig
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
{% set metadata = dataTable.getAllTableMetadata%}
{% set consideredVisits = 'Insights_TitleConsideredVisits'|translate(metadata.minGrowthPercent, metadata.lastDate|prettyDate(metadata.period)) %}
{% set consideredChanges = '' %}

<div class="insightsDataTable" title="{{ consideredVisits|e('html_attr') }}">
{% if metadata.minChangeMovers and metadata.minChangeMovers > 1 %}
{% set consideredChanges = 'Insights_TitleIgnoredChanges'|translate(metadata.minChangeMovers) %}
{% endif %}

<div class="insightsDataTable" title="{{ consideredVisits|e('html_attr') }} {{ consideredChanges|e('html_attr') }}">
{% if dataTable.getRowsCount > 0 %}
<table class="dataTable">
<thead>
Expand Down

0 comments on commit 593dbc8

Please sign in to comment.