Refs #4877 Tweak the feedback@piwik email subject ftw

matomo-org · May 13, 2014 · 56aedb8 · 56aedb8
1 parent 338d3ad
commit 56aedb8
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/plugins/Feedback/API.php b/plugins/Feedback/API.php
@@ -44,13 +44,20 @@ public function sendFeedbackForFeature($featureName, $like, $message = false)
         }
 
         $body = sprintf("Feature: %s\nLike: %s\n", $featureName, $likeText, $message);
-        if (!empty($message)) {
-            $body .= sprintf("Feedback:\n%s\n", $message);
-        } else {
-            $body .= "No feedback\n";
+
+        $feedbackMessage = '';
+        if (!empty($message) && $message != 'undefined') {
+            $feedbackMessage = sprintf("Feedback:\n%s\n", trim($message));
         }
+        $body .= $feedbackMessage;
+
+        $subject = sprintf("%s for %s %s",
+            empty($like) ? "-1" : "+1",
+            $featureName,
+            empty($feedbackMessage) ? "" : "(w/ feedback)"
+        );
 
-        $this->sendMail($featureName, $body);
+        $this->sendMail($subject, $body);
     }
 
     private function sendMail($subject, $body)