refs #57 fix tests

matomo-org · Mar 3, 2014 · 4de7581 · 4de7581
1 parent 727da1b
commit 4de7581
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/plugins/Insights/DataTable/Filter/Insight.php b/plugins/Insights/DataTable/Filter/Insight.php
@@ -68,7 +68,11 @@ public function filter($table)
                 $oldValue   = $row->getColumn($this->columnValueToRead);
                 $difference = $newValue - $oldValue;
 
-                $growthPercentage = '-100%';
+                if ($oldValue == 0 && $newValue == 0) {
+                    $growthPercentage = '0%';
+                } else {
+                    $growthPercentage = '-100%';
+                }
 
                 $this->addRow($table, $row, $growthPercentage, $newValue, $oldValue, $difference);
             }

diff --git a/plugins/Insights/tests/FilterInsightTest.php b/plugins/Insights/tests/FilterInsightTest.php
@@ -164,7 +164,7 @@ public function testShouldCalculateDifferenceAndGrowthPercentage()
             array('label' => 'val9', 'growth_percent' => '-90.3%', 'growth_percent_numeric' => '-90.3', 'difference' => -65),
             array('label' => 'val10', 'growth_percent' => '100%', 'growth_percent_numeric' => '100', 'difference' => 89),
             array('label' => 'val102', 'growth_percent' => '-100%', 'growth_percent_numeric' => '-100', 'difference' => -29),
-            array('label' => 'val109', 'growth_percent' => '-100%', 'growth_percent_numeric' => '-100', 'difference' => 0),
+            array('label' => 'val109', 'growth_percent' => '0%', 'growth_percent_numeric' => '0', 'difference' => 0),
             array('label' => 'val107', 'growth_percent' => '-100%', 'growth_percent_numeric' => '-100', 'difference' => -415),
         );