refs #57 make sure text ellipsis works and label is always only one l…

…ine. moved test fixture to insights plugin as demonstration for other plugin developers as it is very insights related anyway

plugins/Insights/API.php

@@ -58,7 +58,7 @@ public function getInsightsOverview($idSite, $period, $date)
 
             for ($index = $firstTableId; $index <= $lastTableId; $index++) {
                 if (!in_array($index, $reportTableIds)) {
-                    DataTable\Manager::getInstance()->deleteTable($index);
+                    $dataTableManager->deleteTable($index);
                 }
             }
 

plugins/Insights/Controller.php

@@ -13,7 +13,7 @@
 use Piwik\View;
 
 /**
- *
+ * Insights Controller
  */
 class Controller extends \Piwik\Plugin\Controller
 {

plugins/Insights/javascripts/insightsDataTable.js

@@ -40,6 +40,14 @@
             this.initOrderBy(domElem);
             this.initComparedToXPeriodsAgo(domElem);
             this.initFilterBy(domElem);
+            this.setFixWidthToMakeEllipsisWork(domElem);
+        },
+
+        setFixWidthToMakeEllipsisWork: function (domElem) {
+            var width = domElem.width();
+            if (width) {
+                $('td.label', domElem).width(parseInt(width * 0.60, 10));
+            }
         },
 
         _changeParameter: function (params) {

plugins/Insights/tests/ApiTest.php

@@ -11,6 +11,7 @@
 use Piwik\DataTable;
 use Piwik\Plugins\Insights\API;
 use Piwik\API\Request as ApiRequest;
+use Piwik\Plugins\Insights\tests\Fixtures\SomeVisitsDifferentPathsOnTwoDays;
 
 /**
  * @group Insights
@@ -21,7 +22,7 @@
 class ApiTest extends \IntegrationTestCase
 {
     /**
-     * @var \Test_Piwik_Fixture_SomeVisitsDifferentPathsOnTwoDays
+     * @var SomeVisitsDifferentPathsOnTwoDays
      */
     public static $fixture = null;
 
@@ -240,4 +241,4 @@ private function assertRows($expectedLabels, DataTable $dataTable)
     }
 }
 
-ApiTest::$fixture = new \Test_Piwik_Fixture_SomeVisitsDifferentPathsOnTwoDays();
+ApiTest::$fixture = new SomeVisitsDifferentPathsOnTwoDays();

tests/PHPUnit/Fixtures/SomeVisitsDifferentPathsOnTwoDays.php → plugins/Insights/tests/Fixtures/SomeVisitsDifferentPathsOnTwoDays.php

@@ -5,13 +5,15 @@
  * @link    http://piwik.org
  * @license http://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
  */
-use Piwik\Date;
 
+namespace Piwik\Plugins\Insights\tests\Fixtures;
+
+use Piwik\Date;
 /**
  * Adds one website and tracks several visits from one visitor on
  * different days that span about a month apart.
  */
-class Test_Piwik_Fixture_SomeVisitsDifferentPathsOnTwoDays extends Test_Piwik_BaseFixture
+class SomeVisitsDifferentPathsOnTwoDays extends \Test_Piwik_BaseFixture
 {
     public $idSite = 1;
     public $date1  = '2010-12-14';