Skip to content

Commit

Permalink
refs #1915 "columns" is added as a special query parameter in ViewDat…
Browse files Browse the repository at this point in the history
…aTable class which results in having to do this. Problem: Switching to treemap visualization in eg PageUrls will save a columns "nb_hits" param, loading the normal view and sorting by column will result in only displaying nb_hits column instead of all columns. This seems to be the only case. If there are more we need to let the visualization decide which parameters to reset in case of a visualization change
  • Loading branch information
tsteur committed May 19, 2014
1 parent b02e74e commit 1de1cdb
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions core/ViewDataTable/Manager.php
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,13 @@ public static function saveViewDataTableParameters($login, $controllerAction, $p
$params = self::getViewDataTableParameters($login, $controllerAction);

foreach ($parametersToOverride as $key => $value) {
if ($key === 'viewDataTable'
&& !empty($params['columns'])
&& !empty($params[$key])
&& $params[$key] !== $value) {
unset($params['columns']);
}

$params[$key] = $value;
}

Expand Down

0 comments on commit 1de1cdb

Please sign in to comment.