#6622 Logger refactoring: lazily create log writers

core/Log/LoggerFactory.php

@@ -60,7 +60,7 @@ private static function getLogWriters($logConfig, ContainerInterface $container)
             return array();
         }
 
-        $availableWriters = self::getAvailableWriters($container);
+        $availableWriters = self::getAvailableWriters();
 
         $writerNames = array_map('trim', $writerNames);
         $writers = array();
@@ -70,7 +70,12 @@ private static function getLogWriters($logConfig, ContainerInterface $container)
                 continue;
             }
 
-            $writers[$writerName] = $availableWriters[$writerName];
+            $writer = $availableWriters[$writerName];
+            if (is_string($writer)) {
+                $writer = $container->get($writer);
+            }
+
+            $writers[$writerName] = $writer;
         }
 
         // Always add the stderr backend
@@ -114,7 +119,7 @@ private static function getLogLevelFromStringName($name)
         }
     }
 
-    private static function getAvailableWriters(ContainerInterface $container)
+    private static function getAvailableWriters()
     {
         $writers = array();
 
@@ -146,9 +151,9 @@ private static function getAvailableWriters(ContainerInterface $container)
          */
         Piwik::postEvent(Log::GET_AVAILABLE_WRITERS_EVENT, array(&$writers));
 
-        $writers['file'] = $container->get('Piwik\Log\Backend\FileBackend');
-        $writers['screen'] = $container->get('Piwik\Log\Backend\StdOutBackend');
-        $writers['database'] = $container->get('Piwik\Log\Backend\DatabaseBackend');
+        $writers['file'] = 'Piwik\Log\Backend\FileBackend';
+        $writers['screen'] = 'Piwik\Log\Backend\StdOutBackend';
+        $writers['database'] = 'Piwik\Log\Backend\DatabaseBackend';
 
         return $writers;
     }