Goal tracking #273
Merged
Goal tracking #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 6, 2018 14:22
Closed
|
I'm not familiar with the tests but when I run them locally they work with iPhone 6 iOS 9.3 |
|
@ThomasGoehringer No worries. That was the 42-false-negative. A little CI bug that is haunting me for a few weeks now. I've only ever seen it on CI and it appears very rarely. I just kicked the build once again. Should be green in no time. BTW: Thanks for the PR. |
brototyp
approved these changes
Sep 14, 2018
|
Lovely, Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a method for tracking goals with their ID and a revenue connected to that goal.