Feature/111 custom dimensions with action scope #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -260,13 +216,15 @@ extension PiwikTracker { | |||
| /// | |||
| /// - Parameter view: An array of hierarchical screen names. | |||
| /// - Parameter url: The url of the page that was viewed. If none set the url will be http://example.com appended by the screen segments. Example: http://example.com/players/john-appleseed | |||
There was a problem hiding this comment.
The documentation here should mention the dimensions parameter.
PiwikTracker/PiwikTracker.swift
Outdated
| @@ -260,13 +216,15 @@ extension PiwikTracker { | |||
| /// | |||
| /// - Parameter view: An array of hierarchical screen names. | |||
| /// - Parameter url: The url of the page that was viewed. If none set the url will be http://example.com appended by the screen segments. Example: http://example.com/players/john-appleseed | |||
| @objc public func track(view: [String], url: URL? = nil) { | |||
| queue(event: event(action: view, url: url)) | |||
| public func track(view: [String], url: URL? = nil, dimensions: [CustomDimension] = []) { | |||
There was a problem hiding this comment.
As CustomDimension isn't visible to objc, I'm not sure if these methods are still visible to objc.
There was a problem hiding this comment.
There is a Objective-C extension without the dimensions property. See https://github.com/piwik/piwik-sdk-ios/pull/193/files#diff-bd7b3c5478dc6552eb40fd9baaa55d18R289
brototyp
force-pushed
the
feature/111-custom-dimensions-with-action-scope
branch
from
46ec4c5 to
edf632f
Compare
brototyp
force-pushed
the
feature/111-custom-dimensions-with-action-scope
branch
from
edf632f to
39db067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #111 for the action scope.
Basically I made the
CustomDimensionstruct public and added an optional parameter to the tracking functions to add additional dimensions.Since the
CustomDimensionis a struct, it is not usable from Objective-C. Still I think this is the best idea.