-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for Carthage #173
Adds support for Carthage #173
Conversation
Hi @elitalon, thank you very much for your effort! I am not used to use Carthage. Is there any way we can add a Carthage-Build check to the travis file? |
@brototyp I'll see what I can do. I think running |
@brototyp There's a problem with let _ = Timer.scheduledTimer(withTimeInterval: 0.1, repeats: true) { timer in
trackerFixture.tracker.queue(event: EventFixture.event())
} Basically, A quick dirty solution would be using GCD: if #available(iOS 10, *) {
let _ = Timer.scheduledTimer(withTimeInterval: 0.1, repeats: true) { timer in
trackerFixture.tracker.queue(event: EventFixture.event())
}
} else {
var scheduleEventTracking: (() -> Void)?
scheduleEventTracking = {
guard numberOfDispatches < 5 else {
return
}
DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
trackerFixture.tracker.queue(event: EventFixture.event())
scheduleEventTracking?()
}
}
scheduleEventTracking?()
} What do you think? |
@elitalon Your solution might result in wrong test fails. If the |
Great, thanks! #179 is merged. |
Running `pod install` with CocoaPods 1.3.0 caused some project settings to be updated.
For some reason `carthage build --no-skip-current` (and later xcodebuild) complaint about not being able to import UIKit in PiwikTracker.h.
`tvos` has been replaced by `appletvos`.
@brototyp The PR is again ready, but something happened with the Travis build. Do you have any idea? I don't have rights to trigger it again. |
@elitalon I just started the build once again (a third time) and it all went through. Thanks! |
This attempts to fix #74 by solving a few build errors that happen when building with
carthage --no-skip-current
.Theoretically, that should allow projects managed with Carthage to use the framework.