Feature/136 starting sessions #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,6 +24,7 @@ final public class Tracker: NSObject { | |||
| self.queue = queue | |||
| self.dispatcher = dispatcher | |||
| super.init() | |||
| startNewSession() | |||
| startDispatchTimer() | |||
There was a problem hiding this comment.
What do you think of startNewSession() also calling startDispatchTimer()? Are there cases where a new session should not start a new timer?
There was a problem hiding this comment.
I wouldn't call startDispatchTimer() directly, rather dispatch(). dispatch() would dispatch the currently stored events and starts a new timer.
In this case I don't think doing any of those is what we want. Starting a new session is not necessary coupled to dispatching events. What do you think?
There was a problem hiding this comment.
I'm fine with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the #136. I slightly changed the API from
newSession()tostartNewSession()to be more clear about what this does. Also I thought about when to automatically start a new session. I think the minimal setup for a new Session is on app start. So I did not implement it for app foregrounding.