Added a documentation article for logging #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
After discussions, I've removed the "Logger configuration" section because it has to do with DI configuration, which is not yet stable and we don't want to expose it to 3rd party plugins yet. If you still want to read it (I think it's a good example of what will be possible in the future): https://github.com/piwik/developer-documentation/blob/f2606256f41ddd85b350d8c4ad2cf93b2c548bf1/docs/logging.md |
Conflicts: app/helpers/Content/Category/DevelopCategory.php
| $logger->debug('This is a debug message'); | ||
| ``` | ||
|
|
||
| Each of this message will or will not be logged according to the log level configured by the user. Developers should not log conditionally according to the current log level: they should simply log and let the system figure it all out. |
There was a problem hiding this comment.
according to the log level configured by the user
according to the log level configured by the user in their config.ini.php ?
|
Fixed your comments @mattab, merging now. |
mnapoli
added a commit
that referenced
this pull request
Dec 21, 2014
Added a documentation article for logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References matomo-org/matomo#6813
I've added an article to document:
how plugins can override its configurationThe second part was removed because it has a lot to do with DI config, which is still a moving topic. We do not want to expose that API yet.
If you want to see the removed part: https://github.com/piwik/developer-documentation/blob/f2606256f41ddd85b350d8c4ad2cf93b2c548bf1/docs/logging.md
This PR depends on matomo-org/matomo#6813