-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for remote ollama #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am generally in favour of the design, but would like to talk about the new name-value argument (why have you chosen this, what alternatives have you considered, the normal design review stuff :) ) - I suspect "Endpoint" is a bit abstract and may be confusing to users who don't already know what it is.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 97.12% 97.13% +0.01%
==========================================
Files 39 39
Lines 1287 1292 +5
==========================================
+ Hits 1250 1255 +5
Misses 37 37 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a look in the updated doc after removing the "local" from there I am unsure it is very clear that we continue to support the existing local server functionality. @MiriamScharnke what are your thoughts on this. I would love if we could continue to highlight the fact that if the user does not define an Endpoint
, the default behaviour is to connect to the local server "127.0.0.1:11434"
No description provided.