Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for remote ollama #53

Merged
merged 6 commits into from
Jul 24, 2024
Merged

Add support for remote ollama #53

merged 6 commits into from
Jul 24, 2024

Conversation

ccreutzi
Copy link
Member

No description provided.

Copy link
Collaborator

@MiriamScharnke MiriamScharnke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am generally in favour of the design, but would like to talk about the new name-value argument (why have you chosen this, what alternatives have you considered, the normal design review stuff :) ) - I suspect "Endpoint" is a bit abstract and may be confusing to users who don't already know what it is.

+llms/+internal/callOllamaChatAPI.m Show resolved Hide resolved
doc/Ollama.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.13%. Comparing base (d74ec2b) to head (761a843).
Report is 91 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   97.12%   97.13%   +0.01%     
==========================================
  Files          39       39              
  Lines        1287     1292       +5     
==========================================
+ Hits         1250     1255       +5     
  Misses         37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vpapanasta vpapanasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a look in the updated doc after removing the "local" from there I am unsure it is very clear that we continue to support the existing local server functionality. @MiriamScharnke what are your thoughts on this. I would love if we could continue to highlight the fact that if the user does not define an Endpoint, the default behaviour is to connect to the local server "127.0.0.1:11434"

@ccreutzi ccreutzi requested a review from MiriamScharnke July 23, 2024 12:02
README.md Outdated Show resolved Hide resolved
@ccreutzi ccreutzi merged commit bdb84b8 into main Jul 24, 2024
1 check passed
@ccreutzi ccreutzi deleted the remote-ollama branch July 24, 2024 09:44
@adulai adulai removed their request for review July 29, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants