Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input to run tests in parallel #23

Merged
merged 3 commits into from
Aug 3, 2022
Merged

Add input to run tests in parallel #23

merged 3 commits into from
Aug 3, 2022

Conversation

mcafaro
Copy link
Member

@mcafaro mcafaro commented Aug 1, 2022

No description provided.

Copy link
Contributor

@davidbuzinski davidbuzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

README.md Outdated
@@ -59,6 +59,7 @@ The **Run MATLAB Tests** action lets you customize your test run using optional
Input | Description
------------------------- | ---------------
`source-folder` | (Optional) Location of the folder containing source code, relative to the project root folder. The specified folder and its subfolders are added to the top of the MATLAB search path. If you specify `source-folder` and then generate a coverage report, MATLAB uses only the source code in the specified folder and its subfolders to generate the report. You can specify multiple folders using a colon-separated or semicolon-separated list.<br/>**Example:** `source`<br/>**Example:** `source/folderA; source/folderB`
`use-parallel` | (Optional) Whether to run tests in parallel on a self-hosted runner, specified as `false` or `true`. By default, the value is `false` and tests run in serial. If the test runner configuration is suited for parallelization, a `true` value results in tests being run in parallel. This input requires a Parallel Computing Toolbox™ license, and is supported only on self-hosted runners.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like other inputs, should we also say which release is required (R2015a or later)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can if you don't think it will cause more harm than good. R2015a+ is only true if you produce no artifacts. As soon as you start switching on artifacts, that release changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this would be an overkill. Let's keep the text as is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our editor would probably recommend removing the last comma. Would you like to remove it now?

@mcafaro mcafaro merged commit 8b16a1b into main Aug 3, 2022
@davidbuzinski davidbuzinski deleted the mcafaro/use-parallel branch February 6, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants