Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bash issue fix #47

Merged
merged 7 commits into from
Jul 22, 2024
Merged

Bash issue fix #47

merged 7 commits into from
Jul 22, 2024

Conversation

nbhoski
Copy link
Contributor

@nbhoski nbhoski commented Jul 18, 2024

This PR closes #40 and #42

  • Added file check before creating build summary so that it does not hit the exception if plan failure occures

@nbhoski nbhoski requested a review from sameagen-MW July 18, 2024 11:33
@nbhoski nbhoski requested a review from mw-hrastega July 18, 2024 12:22
davidbuzinski
davidbuzinski reviewed Jul 18, 2024
View reviewed changes
sameagen-MW
sameagen-MW approved these changes Jul 19, 2024
View reviewed changes
@nbhoski
Copy link
Contributor Author

nbhoski commented Jul 22, 2024

This PR also closes #44

This was linked to issues Jul 22, 2024
Creating summary table errors out when specifying a non-existent task to run #42
Closed
Consider not using all uppercase for task status #44
Closed
@nbhoski nbhoski merged commit eaee4e4 into main Jul 22, 2024
1 check passed
@nbhoski nbhoski deleted the bash_issue_fix branch July 22, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbuzinski davidbuzinski davidbuzinski left review comments

@mw-hrastega mw-hrastega mw-hrastega approved these changes

@sameagen-MW sameagen-MW sameagen-MW approved these changes

Assignees

@acampbel acampbel

@mw-jsgeorge mw-jsgeorge

@apuvvala-mw apuvvala-mw

Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@nbhoski @mw-hrastega @davidbuzinski @sameagen-MW @acampbel @mw-jsgeorge @apuvvala-mw