-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Summary table under summary section #33
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start. +1 to the double logging with try/catch that Sam mentioned, and the error handling concerns that Mark raised as well.
sameagen-MW
requested changes
Jun 28, 2024
mcafaro
reviewed
Jul 1, 2024
mcafaro
reviewed
Jul 1, 2024
davidbuzinski
approved these changes
Jul 1, 2024
mcafaro
approved these changes
Jul 1, 2024
mcafaro
reviewed
Jul 1, 2024
sameagen-MW
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of last feature of supporting workflow commands in GitHub logs. This PR introduces a
Summary table
under GitHubsSummary
page. as shown below. This feture usesBuildSummaryPlugin.m
file for generatingbuildSummary_<RUN_ID>
underRUNNER_TEMP
folder. Which is further used to generate the summary table as shown below. Unit test are included underbuildSummary.unit.test.ts
All Passed
Skipped
Failed