Build options #16
Merged
Build options #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameagen-MW
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
The changes look good to me!
For naming, I think that additional-build-options seems a little bit verbose, and could potentially be confusing because I'm not sure it will be clear to all users what additional refers to here.
How about something like buildtool-options or build-tool-options?
mw-hrastega
approved these changes
Jan 25, 2024
davidbuzinski
approved these changes
Jan 25, 2024
mcafaro
reviewed
Jan 25, 2024
* use new run-command version * update package-lock too
mcafaro
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip/continueOnFailure-ignoreUnknownOptionsflag to handle buildtool calls for older releasesApart from the usual code review, looking for views on naming the parameter
additional-build-optionsUPDATE: Common parameter name finalized as
build-optionsand removed automatically appending-ignoreUnknownOptionsflag