ethclient: handle single state-sync tx in get block calls #1435
+11
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to previous PR: #1409
Description
This PR resolves an issue where blocks containing system transactions could not be retrieved properly using
getBlock
.For such blocks, the
transactionsRoot
is set toEmptyTxsHash
, but theTransactions
list contains one transaction, which leads to a mismatch and prevents block information from being retrieved.The validation logic has been updated to handle these cases correctly.
Example block with system transaction: https://amoy.polygonscan.com/block/16653120
Changes
Breaking changes
No breaking changes have been introduced in this PR.
Nodes audience
This PR affects all nodes and does not include changes limited to a subset of nodes.
Checklist
Cross repository changes
Testing
Manual tests
transactionsRoot
asEmptyTxsHash
but includingTransactions
).Additional comments
See the example block for context:
https://amoy.polygonscan.com/block/16653120