Remove newline from RE_DIFF_GIT_{DELETED,NEW}_FILE #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RE_DIFF_GIT_DELETED_FILE and RE_DIFF_GIT_NEW_FILE match on a complete line pattern 'r^$' so including `\n` in the pattern leads to the pattern not matching. Remove the `\n`.
|
Thanks for the report and the PR, will take a look in the coming days (and probably prepare a release soon after) 👍 |
kergoth
added a commit
to kergoth/meta-sokol-flex
that referenced
this pull request
Sep 6, 2022
Upgrade from 0.7.3 to 0.7.4 to pick up matiasb/python-unidiff#97. This fixes the warning encountered when running python3:do_archive_release_downloads. JIRA: SB-20262 Signed-off-by: Christopher Larson <[email protected]>
kergoth
added a commit
to kergoth/meta-sokol-flex
that referenced
this pull request
Sep 7, 2022
Apply the fix from matiasb/python-unidiff#97. This fixes the warning encountered when running python3:do_archive_release_downloads. JIRA: SB-20262 Signed-off-by: Christopher Larson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE_DIFF_GIT_DELETED_FILE and RE_DIFF_GIT_NEW_FILE match on a complete
line pattern 'r^$' so including
\nin the pattern leads to the patternnot matching. Remove the
\n.