Shortcut for building patch sets from strings #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a class method to PatchSet that wraps a string in StringIO, to be read by __init__.
|
Looks good, would you add a test for it? |
|
The tests are failing on my machine, but I'm not totally sure why (the loaded patch sets themselves look identical when printed). Any insight? |
|
Hey, I was just checking this. The problem is that the default implementation of eq in the Line object does not work as we would like (by default it uses the id of objects for comparison), and that's why expected != actual. |
|
I merged the PR implementing eq for lines, if you rebase when you get a few minutes, I would expect your tests to pass. |
|
Added from_string to master (with minor changes), thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a class method to PatchSet that wraps a string in
StringIO, to be read by__init__.Addresses #26