-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: create new packages for supported frameworks #387
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit be79745:
|
Thank you so much for creating this pull request and responding to my "issue"! I'm really excited about the project and it would be wonderful if I could replace my GoldenLayout project and switch to this. The new structure will definitely make it easier for me and other developers to work on a Vue version (or versions for other frameworks). As soon as I get deep enough into the project, I would definitely try to participate and contribute source code. Having a layout manager of the quality of dockview for our Vue project would be very important at the moment. It would be great if you could contact me at [email protected] so that we can discuss how we can drive the development forward (and perhaps also provide a little financial support). Thanks! |
I would love to see a version for Solid-js! |
debd67e
to
6cd20b2
Compare
@eclipse313 This probably has your interest. Got a basic vue version working. I did not use portals, just straight up rendered the components which seems to work. There are some kinks that i havent figured out. I will not be actively maintaining a vue port, but i can help get it up and running. |
That sounds very interesting, thank you for your work! Once you've pushed it, I'll have a look to see if I can find the cause of the missing reactive. By "props for panel" do you mean that when I assign props to the component, they don't update? |
It is very cluttered. But there is a half working version up https://github.com/BlueBazze/dockview/tree/master/packages/dockview-vue I used the default vue templates to create the package. ESlint also throws a bunch of errors. I didnt include vue eslinting. |
@mathuo Now that i think of it.. Would you rather have us make a pr based on master or this pr branch? |
This branch is a little experimental. If you have a working example for Vue then I'm happy to accept that as a PR from your own branch. I'm currently in the process of preparing v1.10.0 which has a few large features but after that is released I'm hoping to have some time to look into multiple framework support, specifically getting both a Vue and an Angular package created. Awesome work though getting a working Vue example! |
…athuo/dockview into 172-zero-dependency-vanilla-js
84d6da0
to
be79745
Compare
@techbech @husayt @KyDenZ @artaommahe @eclipse313 @jcuenod @BlueBazze As of version Also find the raw list of examples @ dockview.dev/templates. I will be closing this PR and any further discussions can be added here. |
This is great @mathuo. thank you. |
Great work! |
No description provided.