Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create new packages for supported frameworks #387

Closed
wants to merge 3 commits into from

Conversation

mathuo
Copy link
Owner

@mathuo mathuo commented Nov 8, 2023

No description provided.

@mathuo mathuo linked an issue Nov 8, 2023 that may be closed by this pull request
Copy link

codesandbox-ci bot commented Nov 8, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit be79745:

Sandbox Source
customheader-dockview Configuration
dockview-app Configuration
editor-gridview Configuration
events-dockview Configuration
externaldnd-dockview Configuration
fullwidthtab-dockview Configuration
iframe-dockview Configuration
keyboard-dockview Configuration
lockedgroup-dockview Configuration
nativeapp-dockview Configuration
nested-dockview Configuration
rendering-dockview Configuration

@eclipse313
Copy link

Thank you so much for creating this pull request and responding to my "issue"! I'm really excited about the project and it would be wonderful if I could replace my GoldenLayout project and switch to this.

The new structure will definitely make it easier for me and other developers to work on a Vue version (or versions for other frameworks). As soon as I get deep enough into the project, I would definitely try to participate and contribute source code.

Having a layout manager of the quality of dockview for our Vue project would be very important at the moment. It would be great if you could contact me at [email protected] so that we can discuss how we can drive the development forward (and perhaps also provide a little financial support).

Thanks!
Thomas

@jcuenod
Copy link

jcuenod commented Nov 13, 2023

I would love to see a version for Solid-js!
Edit: looks like someone is working on this: https://github.com/lyonbot/solid-dockview

@mathuo mathuo force-pushed the 172-zero-dependency-vanilla-js branch from debd67e to 6cd20b2 Compare November 14, 2023 21:40
@BlueBazze
Copy link

BlueBazze commented Feb 12, 2024

@eclipse313 This probably has your interest.

Got a basic vue version working.
Theres a bunch of stuff that does not work yet.

I did not use portals, just straight up rendered the components which seems to work.

There are some kinks that i havent figured out.
It seems that the props for panel, header and watermark components cannot access the api title and so on without updating, update another ref, basically the props are not reactive and i have no idea how to make them reactive..

I will not be actively maintaining a vue port, but i can help get it up and running.
At the moment i just did everything inside of a vue project, ill extract and publish it tomorrow.

image

@eclipse313
Copy link

That sounds very interesting, thank you for your work! Once you've pushed it, I'll have a look to see if I can find the cause of the missing reactive. By "props for panel" do you mean that when I assign props to the component, they don't update?

@BlueBazze
Copy link

BlueBazze commented Feb 15, 2024

It is very cluttered. But there is a half working version up https://github.com/BlueBazze/dockview/tree/master/packages/dockview-vue

I used the default vue templates to create the package.
There is probably some configuration needed for vite to build the actual package.
So at the moment im guessing only the playground works.

ESlint also throws a bunch of errors. I didnt include vue eslinting.

@BlueBazze
Copy link

@mathuo Now that i think of it.. Would you rather have us make a pr based on master or this pr branch?

@mathuo
Copy link
Owner Author

mathuo commented Feb 17, 2024

@mathuo Now that i think of it.. Would you rather have us make a pr based on master or this pr branch?

This branch is a little experimental. If you have a working example for Vue then I'm happy to accept that as a PR from your own branch.

I'm currently in the process of preparing v1.10.0 which has a few large features but after that is released I'm hoping to have some time to look into multiple framework support, specifically getting both a Vue and an Angular package created.

Awesome work though getting a working Vue example!

@mathuo mathuo force-pushed the 172-zero-dependency-vanilla-js branch from 84d6da0 to be79745 Compare March 4, 2024 20:28
@mathuo
Copy link
Owner Author

mathuo commented May 30, 2024

@techbech @husayt @KyDenZ @artaommahe @eclipse313 @jcuenod @BlueBazze

As of version 1.14.0 dockview-vue is offically supported. I am in the process of updating the docs @ dockview.dev where there are also some examples and the framework can be toggled to show examples in Vue.

image

Also find the raw list of examples @ dockview.dev/templates.

I will be closing this PR and any further discussions can be added here.

@mathuo mathuo closed this May 30, 2024
@husayt
Copy link

husayt commented May 31, 2024

This is great @mathuo. thank you.

@BlueBazze
Copy link

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zero dependency (vanilla js)
5 participants