Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the bboldx package. #1056

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Adds the bboldx package. #1056

merged 3 commits into from
Mar 7, 2024

Conversation

zorkow
Copy link
Member

@zorkow zorkow commented Feb 12, 2024

Implements the bboldx package

Requires the bboldx fonts from https://github.com/mathjax/MathJax-fonts/pull/3

@zorkow zorkow requested a review from dpvc February 12, 2024 16:03
@dpvc dpvc added this to the v4.0 milestone Feb 17, 2024
Comment on lines +56 to +59
// add text macros by default to textmacros
textmacros: {
packages: {'[+]': ['text-bboldx']}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an interesting approach, and I'm trying to decide if I like it or not. We don't do this for textcomp, and I think it should probably consistent, one way or the other. We do require people to no only load a package but actually add it to the tex.packages configuration as well, so I'm not sure why it is right to add to the textmacros packages automatically. Perhaps we should discuss it in our next meeting.

Update config file and dependencies (bboldx)
Copy link
Member

@dpvc dpvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zorkow zorkow merged commit 888a09a into develop Mar 7, 2024
@zorkow zorkow deleted the package/bboldx branch March 7, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants