Test to specify licenseSet includes from CLI

[mathieu]

Added an IT test to reproduce the solution provided in #536. In the tri-license-set-with-includes integration test we have 3 licenseSets and would only need to format the Unformatted2.java file via the command line.

On needs to update the license-maven-plugin/src/it/tri-license-set-with-includes/invoker.properties files to test others ways of setting this.

It fails for me with the following variations:

invoker.goals=license:format -Dlicense.licenseSets.licenseSet.includes=src/main/java/com/mycila/it/Unformatted2.java
invoker.goals=license:format -Dlicense.licenseSet.includes=src/main/java/com/mycila/it/Unformatted2.java
invoker.goals=license:format -Dlicense.includes=src/main/java/com/mycila/it/Unformatted2.java

[mathieucarbou]

The third flavor is the one that existed before and was deprecated:

license-maven-plugin/license-maven-plugin/src/main/java/com/mycila/maven/plugin/license/AbstractLicenseMojo.java

Line 209 in fceb1b2

@Parameter(alias = "includes", property = "license.includes")

But to be considered, a nearly complete legacy config has to be provided:

license-maven-plugin/license-maven-plugin/src/main/java/com/mycila/maven/plugin/license/AbstractLicenseMojo.java

Lines 569 to 571 in fceb1b2

	if (legacyConfigHeader == null && (this.legacyConfigInlineHeader == null || this.legacyConfigInlineHeader.isEmpty())) {
	return null;
	}

licenseSets is an array here, and no property is attached so it cannot be accessed:

license-maven-plugin/license-maven-plugin/src/main/java/com/mycila/maven/plugin/license/AbstractLicenseMojo.java

Lines 87 to 88 in fceb1b2

	@Parameter
	public LicenseSet[] licenseSets;

I think we should add one, yes, like you did in this PR, so that you an do for example:

mvn license:format -Dlicense.licenseSets[0].includes=src/main/java/com/mycila/it/Unformatted2.java -Dlicense.licenseSets[0].excludes=src/main/java/com/mycila/it/Unformatted1.java

I will try that... Anyway, this PR updating the properties make sense.

[mathieucarbou]

@mathieu : the test initial states are wrong IMO.

The pom config should reflect the correct state of the project. So if we have this:

            <licenseSet>
              <header>mock-license-1.txt</header>
              <excludes>
                <exclude>invoker.properties</exclude>
                <exclude>pom.xml</exclude>
                <exclude>*.groovy</exclude>
                <exclude>**/*.bak</exclude>
                <exclude>*.log</exclude>
                <exclude>mock-license-*</exclude>
                <exclude>**/Unformatted2.java</exclude>
                <exclude>**/Unformatted3.java</exclude>
              </excludes>
            </licenseSet>
            <licenseSet>
              <header>mock-license-2.txt</header>
              <excludes>
                <exclude>invoker.properties</exclude>
                <exclude>pom.xml</exclude>
                <exclude>*.groovy</exclude>
                <exclude>**/*.bak</exclude>
                <exclude>*.log</exclude>
                <exclude>mock-license-*</exclude>
                <exclude>**/Unformatted1.java</exclude>
                <exclude>**/Unformatted3.java</exclude>
              </excludes>
            </licenseSet>
            <licenseSet>
              <header>mock-license-3.txt</header>
              <includes>
                <include>**/Unformatted3.java</include>
              </includes>
            </licenseSet>

And we commit the file Unformatted2.java, It means that in main, I should have all the files according to the filters formatted with the correct license. Which means Unformatted1 and 3 should be formatted correctly already.

To simulate a commit-hook acting on a new file, Unformatted1.java and Unformatted3.java should be formatted because Unformatted2.java is the one added if I understand your invoker command.

Also, the commit hook should consider the number of license check definitions in the POM.

If I correct the initial state and update the invoker command like that, it works:

invoker.goals=license:format -Dlicense.licenseSets[0].includes=src/main/java/com/mycila/it/Unformatted2.java -Dlicense.licenseSets[1].includes=src/main/java/com/mycila/it/Unformatted2.java -Dlicense.licenseSets[2].includes=src/main/java/com/mycila/it/Unformatted2.java

In this example, Unformatted2.java is the new file added in the commit and the commit hook will format it based on the second header style.