set real "Last-Modified" header based on file's LastWrite time #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get file's LastWrite timestamp for file handlers (if supported by FS driver)
and construct proper "Last-Modified" header. Works fine for LittleFS.
If not supported by FS than fallback to previous implementation with manual value for "Last-Modified".
an example code to serve static files from LittleFS with IMS revalidation
```
// serve all static files from LittleFS root /
server.serveStatic("/", LittleFS, "/")
.setDefaultFile("index.html")
.setCacheControl("must-revalidate"); // revalidate based on etag/IMS headers
```
Signed-off-by: Emil Muratov <[email protected]>
mathieucarbou
requested changes
Jan 26, 2024
|
@vortigont : you are currently using this mod in your app ? Can you confirm it is tested and works fine ? |
yes, I'm using this feature for quite a long time, works perfectly. |
mathieucarbou
requested changes
Jan 26, 2024
|
OK, I've rolled back code to C style and kept as much old code as possible. |
mathieucarbou
requested changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get file's LastWrite timestamp for file handlers (if supported by FS driver) and construct proper "Last-Modified" header. Works fine for LittleFS. If not supported by FS than fallback to previous implementation with manual value for "Last-Modified".
an example code to serve static files from LittleFS with IMS revalidation