Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module export formats shouldn't be mutually exclusive #47

Closed
andyearnshaw opened this issue Jun 8, 2016 · 0 comments · Fixed by #48
Closed

Module export formats shouldn't be mutually exclusive #47

andyearnshaw opened this issue Jun 8, 2016 · 0 comments · Fixed by #48

Comments

@andyearnshaw
Copy link

See nodejs/node#7224 for context. To summarise, if punycode.js detects a global AMD define, then nodeRequire('url').parse('http://foo.bar/baz) breaks because punycode exports nothing for Node's require.

A good solution to this would be to call both define() and assign to module.exports if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant