Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce the showLoadingSpinner prop in TableView.svelte #4222

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

abab-dev
Copy link
Contributor

Fixes #4169

Introduce the new prop showLoadingSpinner with default value true.
Whenever we do not want to show the spinner,
we will set it to false and spinner will not be shown.

Screenshots

output.mp4

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Sorry, something went wrong.

@zackkrida zackkrida requested a review from seancolsen February 1, 2025 19:17
@zackkrida zackkrida added the pr-status: review A PR awaiting review label Feb 1, 2025
Copy link
Contributor

@seancolsen seancolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abab-dev but I had to changes the logic a bit in 36e8080 since w still want to show the loading spinner in the table widget before any of the columns have loaded.

@seancolsen seancolsen enabled auto-merge February 4, 2025 01:54
@seancolsen seancolsen added this pull request to the merge queue Feb 4, 2025
Merged via the queue into mathesar-foundation:develop with commit 81aea71 Feb 4, 2025
70 checks passed
@seancolsen seancolsen mentioned this pull request Feb 26, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spinner is displayed in addition to the table loading state in Record page
3 participants