Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this great library!
I was playing with rotated ellipses and noticed a bug in how the rotation angle is extracted from the transform function.
Essentially,
arccos
wasn't computing the right sign for some angles, so I replaced it witharctan2
and added a bunch of unit tests.Reproducer:
Before this PR, the following input
generated these arc paths:
Note: The angle is 45 degrees instead of -45 degrees, which is rendered as:
(note: I changed the fill color for easier comparison).
After this PR, the correct arc paths are produced: