Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing /src in doc links to source code #4032

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

DanielYang59
Copy link
Contributor

@DanielYang59 DanielYang59 commented Sep 3, 2024

closes #4030

  • Fix missing src in hyperlinks to source code in docs

@janosh janosh added fix Bug fix PRs docs Documentation, examples, user guides labels Sep 3, 2024
@janosh janosh changed the title Fix hyperlinks to source code in docs Fix missing /src in doc links to source code Sep 3, 2024
Copy link
Member

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @DanielYang59! 👍

@janosh janosh merged commit edcd465 into materialsproject:master Sep 3, 2024
2 checks passed
@DanielYang59
Copy link
Contributor Author

No problem. Thanks for the better title :)

@DanielYang59 DanielYang59 deleted the fix-doc-link branch September 3, 2024 08:41
@DanielYang59
Copy link
Contributor Author

DanielYang59 commented Sep 4, 2024

Looks like there might be a off-by-one error with the URL generator, need a closer look:
image

This only happens for some classes, in https://pymatgen.org/pymatgen.alchemy.html, line indexes for AbstractStructureFilter is correct, but ChargeBalanceFilter is off-by-one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation, examples, user guides fix Bug fix PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Links to source in each function returns a 404 error
2 participants