Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import sorting #3968

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Fix import sorting #3968

merged 2 commits into from
Aug 2, 2024

Conversation

janosh
Copy link
Member

@janosh janosh commented Aug 2, 2024

fix the import sorting issue affecting many PRs after 9100860 didn't ensure pymatgen is recognized as a first-party package

@janosh janosh added linting Linting and quality assurance imports Import changes and formatting dx Developer experience labels Aug 2, 2024
@janosh janosh requested review from shyuep and mkhorton as code owners August 2, 2024 21:55
@janosh janosh merged commit b955eec into master Aug 2, 2024
31 of 33 checks passed
@janosh janosh deleted the fix-import-sorting branch August 2, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyuep shyuep Awaiting requested review from shyuep shyuep is a code owner

@mkhorton mkhorton Awaiting requested review from mkhorton mkhorton is a code owner

Assignees
No one assigned
Labels
dx Developer experience imports Import changes and formatting linting Linting and quality assurance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@janosh