-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix d2k function #3932
Fix d2k function #3932
Conversation
Need to use the transpose of the inverse matrix for recipmatrix
Any updates on if this can get merged in? |
e3fbc67
to
41e6d99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @tpurcell90! 👍 could you add a test that fails without this fix?
Test added via static-no-kgrid-si test. Unit test can also be added if you prefer that too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! 👍
All tests pass locally
Head branch was pushed to by a user without write access
should fix error in tests
Need to use the transpose of the inverse matrix for recipmatrix
Summary
Major changes:
Checklist
ruff
.mypy
.duecredit
@due.dcite
decorators to reference relevant papers by DOI (example)Tip: Install
pre-commit
hooks to auto-check types and linting before every commit: