Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace expired BoltzTraP link #3929

Merged
merged 7 commits into from
Jul 24, 2024
Merged

Replace expired BoltzTraP link #3929

merged 7 commits into from
Jul 24, 2024

Conversation

DanielYang59
Copy link
Contributor

@DanielYang59 DanielYang59 commented Jul 17, 2024 •
edited
Loading

Summary

@DanielYang59 DanielYang59 changed the title Fix expired BoltzTraP link Replace expired BoltzTraP link Jul 18, 2024
@DanielYang59
Copy link
Contributor Author

@janosh Would appreciate it if you could review this as well, thanks!

janosh
janosh approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @DanielYang59, looks good! 👍

@janosh janosh added docs Documentation, examples, user guides electronic structure Electronic structure functionality related labels Jul 24, 2024
@janosh janosh merged commit 44b8c6e into materialsproject:master Jul 24, 2024
33 checks passed
@DanielYang59 DanielYang59 deleted the fix-boltztrap-link branch July 24, 2024 11:21
@DanielYang59
Copy link
Contributor Author

Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janosh janosh janosh approved these changes

@shyuep shyuep Awaiting requested review from shyuep shyuep is a code owner

@mkhorton mkhorton Awaiting requested review from mkhorton mkhorton is a code owner

Assignees
No one assigned
Labels
docs Documentation, examples, user guides electronic structure Electronic structure functionality related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Ext] The link to boltztrap is not valid anymore
2 participants
@DanielYang59 @janosh