Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ValueError: Invalid fmt with Structure.to(fmt='yml') #3557

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

janosh
Copy link
Member

@janosh janosh commented Jan 16, 2024

96bbf50 fix Structure.to(fmt='yml'), add Structure.FileFormats to ensure consistent format support and value err msg in Structure.to and Structure.from_file
02593cd test_structure.py cover fmt='yml' in test_to_from_file_string

…istent format support and value err msg in Structure.to and Structure.from_file
@janosh janosh added io Input/output functionality fix Bug fix PRs core Pymatgen core labels Jan 16, 2024
@janosh janosh enabled auto-merge (squash) January 16, 2024 09:43
@janosh janosh merged commit c14d67e into master Jan 16, 2024
22 checks passed
@janosh janosh deleted the fix-struct-to-fmt-yml branch January 16, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Pymatgen core fix Bug fix PRs io Input/output functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant