Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Issue Templates #3528

Merged
merged 6 commits into from
Dec 20, 2023
Merged

Add GitHub Issue Templates #3528

merged 6 commits into from
Dec 20, 2023

Conversation

DanielYang59
Copy link
Contributor

@DanielYang59 DanielYang59 commented Dec 20, 2023 •
edited
Loading

Summary

This pull request addresses suggestions to solve #3449 by adding two new issue templates.

Major changes:

  • Added a new issue template for "Bug Report."
  • Included an issue template for "Feature Request," aligning it with the original issue template format.

Please feel free to provide any suggestions or feedback.

janosh
janosh suggested changes Dec 20, 2023
View reviewed changes
.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yaml Outdated Show resolved Hide resolved
@DanielYang59 DanielYang59 requested a review from janosh December 20, 2023 03:44
@DanielYang59
Copy link
Contributor Author

Changes made accordingly. Thanks for your explainations here.

janosh
janosh approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DanielYang59 👍

@janosh janosh merged commit e185bc1 into materialsproject:master Dec 20, 2023
21 of 22 checks passed
@DanielYang59
Copy link
Contributor Author

@janosh Thanks for reviewing and the comments. Actually my first time PR, just started to working in the community and would try to keep working with you guys.

@janosh
Copy link
Member

janosh commented Dec 20, 2023

That sounds great! The more, the merry! 😄

@DanielYang59 DanielYang59 deleted the issue_template branch December 20, 2023 04:05
@DanielYang59 DanielYang59 mentioned this pull request Dec 21, 2023
Merged
@janosh janosh added the dx Developer experience label Dec 21, 2023
@janosh janosh mentioned this pull request Jan 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janosh janosh janosh approved these changes

Assignees
No one assigned
Labels
dx Developer experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielYang59 @janosh