Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pdplotter.show with matplotlib backend #3493

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Fix pdplotter.show with matplotlib backend #3493

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
826800d
Merge branch 'master' of https://github.com/materialsproject/pymatgen
lbluque Oct 13, 2023
093736f
Merge branch 'master' of https://github.com/materialsproject/pymatgen
lbluque Dec 4, 2023
272efc6
BUG: fix pdplotter.show with matplotlib backend
lbluque Dec 5, 2023
6cd0dc1
add better tests for PDPlotter.get_plot() and show()
janosh Dec 6, 2023
20c33e2
fix plotter_ternary_mpl.show() not called in CI
janosh Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pymatgen/analysis/phase_diagram.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2276,7 +2276,11 @@ def show(self, *args, **kwargs) -> None:
*args: Passed to get_plot.
**kwargs: Passed to get_plot.
"""
self.get_plot(*args, **kwargs).show()
plot = self.get_plot(*args, **kwargs)
if self.backend == "matplotlib":
plot.get_figure().show()
else:
plot.show()

def write_image(self, stream: str | StringIO, image_format: str = "svg", **kwargs) -> None:
"""
Expand Down