-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Atoms.cluster_from_file()
in io.feff.inputs
giving wrong number of atoms
#3426
Changes from 37 commits
1dc8c43
bb74a32
fac911d
0018837
8112068
943cbd4
46fbf47
09f0642
2550e26
d2c35c2
c5020c1
18e23bd
1679411
ae62a3a
3fd1904
84392b8
81c1ac5
ccb5106
19896dc
91fab3c
ebcedfe
f036f0a
00da9c8
cde0422
bd25993
95c0b56
80b2ad4
c915adb
844336e
61b5914
6607fa7
e9c3d82
f8ef114
d2cfa6a
cb05b84
6b14744
432a166
4a03535
9151dbd
fcc2751
4417107
9f40a5b
bae05b1
0d3846a
47022dc
883deeb
dcf190c
614cc85
1d5214b
c346c00
dc1b939
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We have 6 or more existing There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
TITLE COC_O3_cut_ori_100_l_5_19_site_0_n_4 | ||
EDGE L3 | ||
S02 0.9 | ||
|
||
COREHOLE FSR | ||
CONTROL 1 1 1 1 1 1 | ||
|
||
FMS 7 0 | ||
EXCHANGE 0 1 0 2 | ||
SCF 7 0 100 0.1 1 | ||
DEBYE 80 230 0 | ||
|
||
|
||
XANES 20 0.05 0.1 | ||
|
||
POTENTIALS | ||
0 78 Pt | ||
1 78 Pt | ||
|
||
|
||
POTENTIALS | ||
* ipot Z element l_scmt l_fms stoichiometry | ||
0 78 Pt -1 -1 0.001 0 | ||
1 78 Pt -1 -1 37 0 | ||
|
||
ATOMS | ||
0 0 0 0 Pt 0 0 | ||
-1.386 -1.386 1.96 1 Pt 2.77193 16 | ||
1.386 1.386 1.96 1 Pt 2.77193 17 | ||
1.386 -1.386 1.96 1 Pt 2.77193 21 | ||
0 -2.772 0 1 Pt 2.772 1 | ||
2.772 0 0 1 Pt 2.772 3 | ||
2.772 -2.772 0 1 Pt 3.9202 4 | ||
4.158 1.386 1.96 1 Pt 4.8012 23 | ||
4.158 -1.386 1.96 1 Pt 4.8012 22 | ||
1.386 -4.158 1.96 1 Pt 4.8012 20 | ||
-1.386 -4.158 1.96 1 Pt 4.8012 19 | ||
5.544 0 0 1 Pt 5.544 5 | ||
0 -5.544 0 1 Pt 5.544 2 | ||
4.158 -4.158 1.96 1 Pt 6.19835 28 | ||
2.772 -5.544 0 1 Pt 6.19838 7 | ||
5.544 -2.772 0 1 Pt 6.19838 9 | ||
-1.386 -6.93 1.96 1 Pt 7.334 18 | ||
6.93 1.386 1.96 1 Pt 7.334 24 | ||
1.386 -6.93 1.96 1 Pt 7.334 26 | ||
6.93 -1.386 1.96 1 Pt 7.334 30 | ||
5.544 -5.544 0 1 Pt 7.8404 10 | ||
4.158 -6.93 1.96 1 Pt 8.31598 27 | ||
6.93 -4.158 1.96 1 Pt 8.31598 29 | ||
0 -8.316 0 1 Pt 8.316 6 | ||
8.316 0 0 1 Pt 8.316 11 | ||
8.316 -2.772 0 1 Pt 8.76583 12 | ||
2.772 -8.316 0 1 Pt 8.76583 8 | ||
6.93 -6.93 1.96 1 Pt 9.99457 34 | ||
9.702 -1.386 1.96 1 Pt 9.99457 31 | ||
1.386 -9.702 1.96 1 Pt 9.99457 25 | ||
8.316 -5.544 0 1 Pt 9.99459 14 | ||
5.544 -8.316 0 1 Pt 9.99459 13 | ||
4.158 -9.702 1.96 1 Pt 10.7359 32 | ||
9.702 -4.158 1.96 1 Pt 10.7359 36 | ||
8.316 -8.316 0 1 Pt 11.7606 15 | ||
9.702 -6.93 1.96 1 Pt 12.0829 35 | ||
6.93 -9.702 1.96 1 Pt 12.0829 33 | ||
END |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -390,3 +390,9 @@ def test_paths_string(self): | |
] | ||
answer = "\n".join(lines) | ||
assert answer == str(self.paths) | ||
|
||
|
||
def test_atom_num(self): | ||
atoms = Atoms.cluster_from_file("ATOMS_test.inp") | ||
num_atom = 37 | ||
assert len(atoms) != num_atom | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why not test for the expected number of atoms? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi Janosh, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You're missing one level of indentation to make it a method of the test class. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let me fix it. sorry to confuse you. I want it to pass when the expected number of atoms is equal to num_atom and throw an error when the numbers are not equal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.