Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a missing multi element POTCAR file #2796

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

MichaelWolloch
Copy link
Contributor

and reverted the file loading change in commit e3bcad7

Summary

  • Fix 1: Fixed a unit test that failed due to a missing file by actually committing the new file. The unit test was already fixed by @janosh in e3bcad7, by taking another POTCAR, but this kind of defeated the purpose of the test which was to check multi-element POTCARs.

@janosh janosh merged commit e3e9cc3 into materialsproject:master Jan 9, 2023
@janosh
Copy link
Member

janosh commented Jan 9, 2023

@MichaelWolloch Thanks for the fix! 👍

@MichaelWolloch
Copy link
Contributor Author

Thank you @janosh for finding the missing file!

@coveralls
Copy link

Coverage Status

Coverage: 78.019% (-0.7%) from 78.738% when pulling fd99292 on MichaelWolloch:master into 0d2062a on materialsproject:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants