Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer generator over list comprehension where equivalent #2793

Merged
merged 5 commits into from
Jan 6, 2023
Merged

Prefer generator over list comprehension where equivalent #2793

merged 5 commits into from
Jan 6, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Jan 6, 2023

"\.join\(\[(.+)\]\) -> ".join($1)

janosh added 2 commits January 6, 2023 10:16
@janosh
prefer generator over list comprehension where equivalent
bea0b71 
used regex: "\.join\(\[(.+)\]\)
replacement: ".join($1)
@janosh
fix bad replacements
f594e00
@coveralls
Copy link

coveralls commented Jan 6, 2023 •
edited
Loading

Coverage Status

Coverage: 78.737% (-0.001%) from 78.738% when pulling f1f1562 on list-to-gen into c1a7f5d on master.

@janosh janosh enabled auto-merge (squash) January 6, 2023 18:50
@janosh janosh disabled auto-merge January 6, 2023 20:54
@janosh janosh merged commit 0d2062a into master Jan 6, 2023
@janosh janosh deleted the list-to-gen branch January 6, 2023 20:54
@vliegeois vliegeois mentioned this pull request Feb 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janosh @coveralls