Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coord_list_mapping_pbc() #2782

Merged
merged 2 commits into from
Dec 26, 2022
Merged

Fix coord_list_mapping_pbc() #2782

merged 2 commits into from
Dec 26, 2022

Conversation

janosh
Copy link
Member

@janosh janosh commented Dec 26, 2022

coord_list_mapping_pbc() in pymatgen/util/coord_cython.pyx raises

AttributeError: module 'numpy' has no attribute 'int'

inds = np.zeros(len(subset), dtype=np.int) - 1

@coveralls
Copy link

Coverage Status

Coverage: 0.0% (-46.6%) from 46.576% when pulling 6ad8648 on fix-coord_list_mapping_pbc into d947703 on master.

@janosh janosh merged commit def9dae into master Dec 26, 2022
@janosh janosh deleted the fix-coord_list_mapping_pbc branch December 26, 2022 23:01
lbluque pushed a commit to lbluque/pymatgen that referenced this pull request Jan 5, 2023
* fix AttributeError: module 'numpy' has no attribute 'int'

* add missing arg descriptions in doc strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants