Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loose endpoints in NEBPathfinder.string_relax() #2740

Merged
merged 2 commits into from
Nov 18, 2022
Merged

Fix loose endpoints in NEBPathfinder.string_relax() #2740

merged 2 commits into from
Nov 18, 2022

Conversation

janosh
Copy link
Member

@janosh janosh commented Nov 18, 2022

Closes #2732.

@janosh
fix endpoints not kept fixed in NEBPathfinder.string_relax()
fbdd4fd 
due to s and s0 being reference to the same numpy array

also fix pydocstyle D417: Missing argument descriptions in the docstring
(argument(s) end, start are missing descriptions in 'string_relax' docstring)
pymatgen/analysis/path_finder.py:158
@coveralls
Copy link

coveralls commented Nov 18, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-36.3%) to 0.0% when pulling f7df26a on fix-gh-2732 into 58685c4 on master.

@janosh janosh merged commit b793286 into master Nov 18, 2022
@janosh janosh deleted the fix-gh-2732 branch November 18, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loose endpoints in NEB string_relax()
2 participants
@janosh @coveralls