Skip to content

Commit

Permalink
use isinstance syntax
Browse files Browse the repository at this point in the history
  • Loading branch information
DanielYang59 committed Jul 31, 2024
1 parent dda75a9 commit 93f18d6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
2 changes: 1 addition & 1 deletion src/pymatgen/io/vasp/incar_parameters.json
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,7 @@
"type": "bool"
},
"LREAL": {
"type": "Union[bool, str]",
"type": "(bool, str)",
"values": [
false,
true,
Expand Down
4 changes: 0 additions & 4 deletions src/pymatgen/io/vasp/inputs.py
Original file line number Diff line number Diff line change
Expand Up @@ -1015,10 +1015,6 @@ def check_params(self) -> None:
If a tag doesn't exist, calculation will still run, however VASP
will ignore the tag and set it as default without letting you know.
"""
# Need to import Union to support type checking of "LREAL"
# TODO: Use "X | Y" after moving to Python 3.10+, see #3958
from typing import Union # noqa: F401

# Load INCAR tag/value check reference file
with open(os.path.join(module_dir, "incar_parameters.json"), encoding="utf-8") as json_file:
incar_params = json.loads(json_file.read())
Expand Down

0 comments on commit 93f18d6

Please sign in to comment.