Fix jsanitize in contains_flow_or_job
#559
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change in emmet materialsproject/emmet@7735bb1 leads to an error in
contains_flow_or_job
, due to the impossibility to call as_dict on some Enums.This PR adds the
enum_values=True
to handle those cases.In general, I am wondering if it is worth making this check every time a Flow is instantiated.