Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match atomate2 ruff config #464

Merged
merged 9 commits into from
Oct 21, 2023
Merged

Match atomate2 ruff config #464

merged 9 commits into from
Oct 21, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Oct 21, 2023

I don't think we should ignore PT011: pytest-raises-too-broad long-term. Better to add match="expected error message" to all pytest.raises(). But there were 45 violations so I didn't fix all of them.

@janosh janosh added the qa Quality assurance label Oct 21, 2023
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #464 (a34e772) into main (abca261) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
- Coverage   99.86%   99.86%   -0.01%     
==========================================
  Files          20       20              
  Lines        1523     1516       -7     
  Branches      419      419              
==========================================
- Hits         1521     1514       -7     
  Misses          2        2              
Files Coverage Δ
src/jobflow/core/flow.py 100.00% <ø> (ø)
src/jobflow/core/reference.py 100.00% <100.00%> (ø)
src/jobflow/core/state.py 100.00% <ø> (ø)
src/jobflow/core/store.py 100.00% <100.00%> (ø)
src/jobflow/managers/fireworks.py 100.00% <100.00%> (ø)
src/jobflow/managers/local.py 100.00% <100.00%> (ø)
src/jobflow/utils/enum.py 100.00% <100.00%> (ø)
src/jobflow/utils/find.py 100.00% <100.00%> (ø)
src/jobflow/utils/graph.py 100.00% <100.00%> (ø)

Use a set literal when testing for membership
@janosh janosh merged commit d7e6760 into main Oct 21, 2023
7 checks passed
@janosh janosh deleted the match-atomate2-ruff-config branch October 21, 2023 22:12
@janosh janosh added the tests Test all the things label Oct 22, 2023
@janosh janosh mentioned this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
house-keeping qa Quality assurance tests Test all the things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants