Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move undeform_structure function to core utils #999

Merged
merged 1 commit into from
May 2, 2024

Conversation

tsmathis
Copy link
Collaborator

@tsmathis tsmathis commented May 1, 2024

Small refactor to move the undeform_structures function out of the materials builder where it was floating outside the builder class as a helper function.

Moved to emmet-core utils to live with the other util functions.

@tsmathis tsmathis requested a review from munrojm May 1, 2024 21:55
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.03%. Comparing base (9381cc2) to head (598e1c3).
Report is 1 commits behind head on main.

Files Patch % Lines
emmet-core/emmet/core/utils.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #999      +/-   ##
==========================================
- Coverage   90.03%   90.03%   -0.01%     
==========================================
  Files         142      142              
  Lines       13338    13337       -1     
==========================================
- Hits        12009    12008       -1     
  Misses       1329     1329              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@munrojm munrojm added the release:patch Patch updates label May 2, 2024
@munrojm munrojm merged commit 5b5ca7d into main May 2, 2024
10 checks passed
@tsmathis tsmathis deleted the deformation-utils-refactor branch September 16, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants