Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder bug fixes #272

Merged
merged 8 commits into from
Sep 23, 2021
Merged

Builder bug fixes #272

merged 8 commits into from
Sep 23, 2021

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Sep 23, 2021

This PR contains some small builder bug fixes:

  • equilibrium_reaction_energy_per_atom typo fix in summary
  • Ensure composition serializes to dict in provenance builder
  • Ensure +U values are validated for all calculations in validation builder
  • Ensure chemsys processing list is sorted in thermo builder

@munrojm munrojm added the release:patch Patch updates label Sep 23, 2021
@munrojm munrojm added release:minor and removed release:patch Patch updates labels Sep 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021

Codecov Report

Merging #272 (24b9379) into main (9246202) will decrease coverage by 0.00%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
- Coverage   91.77%   91.77%   -0.01%     
==========================================
  Files          42       42              
  Lines        2871     2870       -1     
==========================================
- Hits         2635     2634       -1     
  Misses        236      236              
Impacted Files Coverage Δ
emmet-core/emmet/core/summary.py 88.28% <ø> (ø)
emmet-builders/emmet/builders/vasp/materials.py 81.14% <66.66%> (ø)
emmet-core/emmet/core/provenance.py 94.31% <100.00%> (ø)
emmet-core/emmet/core/vasp/validation.py 85.88% <100.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c8ae3...24b9379. Read the comment docs.

@munrojm munrojm merged commit 25f665e into materialsproject:main Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants