Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix provenance #219

Merged
merged 13 commits into from
Jul 12, 2021
Merged

Fix provenance #219

merged 13 commits into from
Jul 12, 2021

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented Jul 12, 2021

Fixes a number of bugs in the provenance builder

  • Ensures structures are compared rather than SNLs
  • returns to the normal species comparator as OrderDisorder is taking forever
  • serializes string History descriptions back to dictionaries
  • fix a "feature" with pybtex that was causing duplicate references to fail rather than just deduplicate

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2021

Codecov Report

Merging #219 (7327238) into main (0564284) will decrease coverage by 0.01%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
- Coverage   85.98%   85.97%   -0.02%     
==========================================
  Files          37       37              
  Lines        1798     1818      +20     
==========================================
+ Hits         1546     1563      +17     
- Misses        252      255       +3     
Impacted Files Coverage Δ
emmet-builders/emmet/builders/vasp/materials.py 83.62% <ø> (ø)
...met-builders/emmet/builders/vasp/task_validator.py 86.95% <ø> (ø)
emmet-core/emmet/core/settings.py 97.91% <ø> (ø)
emmet-core/emmet/core/provenance.py 95.52% <82.35%> (-1.09%) ⬇️
emmet-core/emmet/core/utils.py 91.04% <88.88%> (-0.49%) ⬇️
emmet-core/emmet/core/vasp/validation.py 85.71% <89.47%> (-0.88%) ⬇️
emmet-core/emmet/core/vasp/material.py 98.27% <100.00%> (+0.06%) ⬆️
emmet-core/emmet/core/vasp/task.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b930660...7327238. Read the comment docs.

@shyamd shyamd added the release:patch Patch updates label Jul 12, 2021
@shyamd shyamd merged commit 517fc8d into main Jul 12, 2021
@shyamd shyamd deleted the fix-provenance branch July 12, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants