Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix oxidation doc composition #217

Merged
merged 4 commits into from
Jun 27, 2021
Merged

Fix oxidation doc composition #217

merged 4 commits into from
Jun 27, 2021

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented Jun 26, 2021

This fixes the serialization of composition in oxidation doc:

  • ensures StructureMetadata uses a charge-free composition or it won't bson into MongoDB
  • ensures OxidationDocBuilder jsanitizes the doc before inserting to ensure proper conversion.

@shyamd shyamd added the release:patch Patch updates label Jun 26, 2021
@shyamd shyamd requested a review from munrojm June 26, 2021 00:27
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2021

Codecov Report

Merging #217 (2cf79b2) into main (9638766) will increase coverage by 0.61%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   85.36%   85.98%   +0.61%     
==========================================
  Files          36       37       +1     
  Lines        1777     1798      +21     
==========================================
+ Hits         1517     1546      +29     
+ Misses        260      252       -8     
Impacted Files Coverage Δ
...lders/emmet/builders/materials/oxidation_states.py 100.00% <100.00%> (ø)
emmet-core/emmet/core/structure.py 100.00% <100.00%> (ø)
emmet-core/emmet/core/oxidation_states.py 92.68% <0.00%> (+19.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9638766...2cf79b2. Read the comment docs.

@shyamd shyamd merged commit a25168c into main Jun 27, 2021
@shyamd shyamd deleted the fix-compositon-serialization branch July 2, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants