-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make species hash and coord hash optional in MoleculeMetadata
#1151
Conversation
This PR closes materialsproject#1149 by making the species hash and coord hash fields optional in `MoleculeMetadata`, only generating them if OpenBabel is installed. In return, it is possible to generate `MoleculeMetadata` without relying on OpenBabel.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1151 +/- ##
==========================================
- Coverage 90.42% 90.41% -0.01%
==========================================
Files 147 147
Lines 14448 14455 +7
==========================================
+ Hits 13065 13070 +5
- Misses 1383 1385 +2 ☔ View full report in Codecov by Sentry. |
Also, if approved, would it be possible to get a version release (or pre-release) after this PR? 🙏 |
Thanks @Andrew-S-Rosen, this seems reasonable. Happy to merge this in if you're satisfied? Will also get a release out ASAP as well |
Yup that'd be great! |
Thank you, @tsmathis!!! |
@Andrew-S-Rosen, we're working through a deployment for a full emmet release, but for now try using the 0.84.3rc6 pre-release and let us know if anything isn't working on your end! |
Thanks! Seems to work! |
This PR closes #1149 by making the species hash and coord hash fields optional in
MoleculeMetadata
, only generating them if OpenBabel is installed. In return, it is possible to generateMoleculeMetadata
without relying on OpenBabel.An alternate approach was given in #1150 where I used
JMolNN
as a fallbak option in place ofOpenBabelNN
, but I feel like the current PR is more suitable because it might be difficult to debug a scenario where a change in the environment's dependencies yields a different hash.To reiterate what I mention in the issue report, the motivation behind this PR is that OpenBabel is a really annoying dependency to require since it is not on PyPI. This means any workflow infrastructure wanting to rely on
MoleculeMetadata
must rely on the user to install OpenBabel from source or Conda unless this PR is merged.