Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Extra.allow from document models #1121

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

tsmathis
Copy link
Collaborator

@tsmathis tsmathis commented Sep 30, 2024

Extra.allow is deprecated as of pydantic 2.0

@tsmathis tsmathis added Core Any updates for Emmet-Core pydantic pydantic-related PRs and issues labels Sep 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.00%. Comparing base (8ece13e) to head (bece212).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1121   +/-   ##
=======================================
  Coverage   90.00%   90.00%           
=======================================
  Files         143      143           
  Lines       13714    13718    +4     
=======================================
+ Hits        12343    12347    +4     
  Misses       1371     1371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmathis tsmathis merged commit 64ad4f2 into main Sep 30, 2024
8 checks passed
@tsmathis tsmathis deleted the pydantic-extra-configs branch September 30, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Any updates for Emmet-Core pydantic pydantic-related PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pydantic.config.Extra is deprecated, use literal values instead (e.g. extra='allow')
2 participants