Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting MPCules PR #926 #1106

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Reverting MPCules PR #926 #1106

merged 4 commits into from
Sep 19, 2024

Conversation

tschaume
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 81.08974% with 59 lines in your changes missing coverage. Please review.

Project coverage is 88.83%. Comparing base (0a8792a) to head (afa88c0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...t/api/routes/molecules/orbitals/query_operators.py 64.06% 46 Missing ⚠️
emmet-core/emmet/core/molecules/summary.py 95.03% 7 Missing ⚠️
emmet-core/emmet/core/qchem/molecule.py 42.85% 4 Missing ⚠️
emmet-core/emmet/core/molecules/orbitals.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1106      +/-   ##
==========================================
- Coverage   89.13%   88.83%   -0.30%     
==========================================
  Files         116      114       -2     
  Lines       10998    10627     -371     
==========================================
- Hits         9803     9441     -362     
+ Misses       1195     1186       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tschaume tschaume merged commit 1dffb90 into main Sep 19, 2024
6 of 8 checks passed
@tschaume tschaume deleted the mpcules_revert branch September 19, 2024 18:34
tschaume added a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants